pitrou commented on code in PR #42108:
URL: https://github.com/apache/arrow/pull/42108#discussion_r1637769682
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -418,6 +418,9 @@ AzureOptions::MakeDataLakeServiceClient() const {
Result<std::string> AzureOptions::GenerateSASToken(
Storage::Sas::BlobSasBuilder* builder, Blobs::BlobServiceClient* client)
const {
+ using SasProtocol = Storage::Sas::SasProtocol;
+ builder->Protocol =
+ blob_storage_scheme == "http" ? SasProtocol::HttpsAndHttp :
SasProtocol::HttpsOnly;
Review Comment:
> Should we validate the value explicitly? If we should validate the value,
we'll do it in `MakeBlobServiceClient()` and `MakeDataLakeServiceClient()`
because it can return `Status::Invalid`.
As long as the value is validated somewhere, I'm fine :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
