WillAyd commented on code in PR #1965:
URL: https://github.com/apache/arrow-adbc/pull/1965#discussion_r1667907543
##########
r/adbcdrivermanager/bootstrap.R:
##########
@@ -19,8 +19,10 @@
# implementation from the repo. We also run this from configure, so do nothing
# if we aren't sitting within the repo (e.g., installing a source package from
a
# tarball).
+dir.create("src/arrow-adbc", showWarnings=FALSE)
+file.copy("../../c/include/arrow-adbc/adbc.h", "src/arrow-adbc/adbc.h")
+
files_to_vendor <- c(
- "../../adbc.h",
"../../c/driver_manager/adbc_driver_manager.h",
Review Comment:
Maybe should also install the adbc_driver_manager.h header into the
arrow-adbc subdirectory? Seems like the only time it is included here is by
adbc_driver_manager.cc so still "works" as is, but in turn this is a bit
inconsistent with how we install that header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
