paleolimbot commented on PR #1965:
URL: https://github.com/apache/arrow-adbc/pull/1965#issuecomment-2214755234
> Not sure what the R failures are currently
The best way to do this is `cd r/adbcdrivermanager && R CMD INSTALL .
--preclean`. You may have to remove some .gitignored files to reproduce the
failure.
I think there are a few things going on. In `bootstrap.R`, I think the
headers were being copied to the wrong folder. The relevant part should read:
```
if (all(file.copy(headers_to_vendor, "src/arrow-adbc"))) {
cat("All files successfully copied to src/arrow-adbc/\n")
} else {
stop("Failed to vendor all headers")
}
```
Another issue is that the R files are all using `#include <adbc.h>`, which
would need to be updated if the headers are copied in this way.
Finally, it looks like `adbc_driver_manager.cc` uses `#include
"adbc_driver_manager.h"`, which should be `#include
"arrow-adbc/adbc_driver_manager.h"` if I'm reading this correctly.
As an optional nit, the Google Style Guide (and all of Arrow C++ and
nanoarrow) use quotes instead of brackets for all `#include`s that are not
standard library ones.
I can help debug more, too later on (I'm travelling at the moment!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
