kou commented on code in PR #1993:
URL: https://github.com/apache/arrow-adbc/pull/1993#discussion_r1669669629
##########
dev/release/rat_exclude_files.txt:
##########
@@ -1,10 +1,10 @@
*.json
*.Rproj
*.Rd
-c/subprojects/fmt.wrap
-c/subprojects/gtest.wrap
-c/subprojects/nanoarrow.wrap
-c/subprojects/sqlite3.wrap
+subprojects/fmt.wrap
+subprojects/gtest.wrap
+subprojects/nanoarrow.wrap
+subprojects/sqlite3.wrap
Review Comment:
Could you keep this list in alphabetical order?
##########
glib/meson.build:
##########
@@ -52,21 +52,13 @@ base_include_directories = [
gi_fatal_warnings = (build_machine.system() != 'windows')
-adbc_build_dir = get_option('adbc_build_dir')
-if adbc_build_dir != ''
- adbc_build_dir = meson.source_root() / adbc_build_dir
-endif
-
-if adbc_build_dir == ''
- adbc_driver_manager = dependency('adbc-driver-manager')
Review Comment:
This is for building `.deb`.
To build `.deb` from one source archive, we can't assume that `c/` is
already installed.
https://github.com/apache/arrow-adbc/blob/66ecd33dceb9b8f9fe513abf99685e21929a7064/ci/linux-packages/debian/rules#L33-L65
Why should we remove this? If we want to remove this, we should use only
Meson to build `.deb`. Should we do it?
##########
glib/adbc-glib/meson.build:
##########
@@ -82,7 +82,7 @@ pkgconfig.generate(libadbc_glib,
description: 'GLib API for ADBC driver manager',
filebase: 'adbc-glib',
name: 'ADBC GLib',
- requires: ['gobject-2.0', 'adbc-driver-manager'],
+ requires: ['gobject-2.0', 'adbc_driver_manager'],
Review Comment:
Why do we need this change?
We're using `adbc-driver-manager.pc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
