WillAyd commented on code in PR #1993:
URL: https://github.com/apache/arrow-adbc/pull/1993#discussion_r1670362983
##########
glib/meson.build:
##########
@@ -52,21 +52,13 @@ base_include_directories = [
gi_fatal_warnings = (build_machine.system() != 'windows')
-adbc_build_dir = get_option('adbc_build_dir')
-if adbc_build_dir != ''
- adbc_build_dir = meson.source_root() / adbc_build_dir
-endif
-
-if adbc_build_dir == ''
- adbc_driver_manager = dependency('adbc-driver-manager')
Review Comment:
Yea I noticed Meson was being built with the --nofallback wrap option so
assumed it would need to find the driver manager lib in the system to work.
Thanks for the link - will give it a read. Definitely not a topic I am
familiar with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
