WillAyd commented on code in PR #1993:
URL: https://github.com/apache/arrow-adbc/pull/1993#discussion_r1670367916


##########
glib/adbc-glib/meson.build:
##########
@@ -82,7 +82,7 @@ pkgconfig.generate(libadbc_glib,
                    description: 'GLib API for ADBC driver manager',
                    filebase: 'adbc-glib',
                    name: 'ADBC GLib',
-                   requires: ['gobject-2.0', 'adbc-driver-manager'],
+                   requires: ['gobject-2.0', 'adbc_driver_manager'],

Review Comment:
   When not using pkgconfig and letting the wrap entry download this for you, 
the name of the lib is just adbc_driver_manager, so this was my best attempt at 
working around the inconsistency between the pkgconfig name and library name. 
   
   Could be a misunderstanding - need to investigate more 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to