etseidl commented on code in PR #6117:
URL: https://github.com/apache/arrow-rs/pull/6117#discussion_r1693215107
##########
parquet/src/file/writer.rs:
##########
@@ -649,13 +649,10 @@ impl<'a, W: Write + Send> SerializedRowGroupWriter<'a, W>
{
));
}
- let file_offset = self.buf.bytes_written() as i64;
-
let map_offset = |x| x - src_offset + write_offset as i64;
let mut builder =
ColumnChunkMetaData::builder(metadata.column_descr_ptr())
.set_compression(metadata.compression())
.set_encodings(metadata.encodings().clone())
- .set_file_offset(file_offset)
Review Comment:
Sorry, maybe this needs to be made clearer in the documentation. The spec
still requires the field to be written so old readers don't break (i.e. it is
still marked `required` in the thrift IDL). The correct behavior now is to
write a 0 here.
Oh, I misunderstood your comment...the write below is correct as this is
writing the copy of the `ColumnMetaData` in the footer. The change in this PR
is to not also write a copy of `ColumnMetaData` at the end of each column chunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
