alamb commented on code in PR #6117:
URL: https://github.com/apache/arrow-rs/pull/6117#discussion_r1695921868
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -682,7 +682,12 @@ impl ColumnChunkMetaData {
self.file_path.as_deref()
}
- /// Byte offset in `file_path()`.
+ /// Byte offset of `ColumnMetaData` in `file_path()`.
+ ///
+ /// Note that the meaning of this field has been inconsistent between
implementations
Review Comment:
👍
##########
parquet/src/file/writer.rs:
##########
@@ -649,13 +649,10 @@ impl<'a, W: Write + Send> SerializedRowGroupWriter<'a, W>
{
));
}
- let file_offset = self.buf.bytes_written() as i64;
-
let map_offset = |x| x - src_offset + write_offset as i64;
let mut builder =
ColumnChunkMetaData::builder(metadata.column_descr_ptr())
.set_compression(metadata.compression())
.set_encodings(metadata.encodings().clone())
- .set_file_offset(file_offset)
Review Comment:
I think removing write_metadata looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
