alamb commented on code in PR #6117:
URL: https://github.com/apache/arrow-rs/pull/6117#discussion_r1693937197
##########
parquet/src/file/writer.rs:
##########
@@ -649,13 +649,10 @@ impl<'a, W: Write + Send> SerializedRowGroupWriter<'a, W>
{
));
}
- let file_offset = self.buf.bytes_written() as i64;
-
let map_offset = |x| x - src_offset + write_offset as i64;
let mut builder =
ColumnChunkMetaData::builder(metadata.column_descr_ptr())
.set_compression(metadata.compression())
.set_encodings(metadata.encodings().clone())
- .set_file_offset(file_offset)
Review Comment:
My understanding is that this code:
```rust
close.metadata = builder.build()?;
```
Sets the metadata that will be eventually written into the file footer.
This code, perhaps what @jhorstmann is referring to (the line numbers
appear to have changed):
```rust
SerializedPageWriter::new(self.buf).write_metadata(&metadata)?;
```
Also seems to write the contents of `close.metadata` into the page.
In this case, it does seem like it could be avoided too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
