etseidl commented on code in PR #6159:
URL: https://github.com/apache/arrow-rs/pull/6159#discussion_r1697548211
##########
parquet/src/encodings/decoding/byte_stream_split_decoder.rs:
##########
@@ -76,11 +94,32 @@ impl<T: DataType> Decoder<T> for ByteStreamSplitDecoder<T> {
let num_values = buffer.len().min(total_remaining_values);
let buffer = &mut buffer[..num_values];
+ let type_size = match T::get_physical_type() {
Review Comment:
For FIXED_LEN_BYTE_ARRAY the size can be anything :( That's why I had to add
non-parameterized versions of the `split_streams` and `join_streams`. I added
some additional likely cases (2 for FLOAT16, 16 for UUID), but for FLBA(5)
there's not much you can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]