alamb commented on code in PR #6159:
URL: https://github.com/apache/arrow-rs/pull/6159#discussion_r1697551535
##########
parquet/src/encodings/decoding/byte_stream_split_decoder.rs:
##########
@@ -76,11 +94,32 @@ impl<T: DataType> Decoder<T> for ByteStreamSplitDecoder<T> {
let num_values = buffer.len().min(total_remaining_values);
let buffer = &mut buffer[..num_values];
+ let type_size = match T::get_physical_type() {
Review Comment:
🤔 yeah -- maybe that is argument enough for creating a different decoder
`VariableSizedByteStreamSplitDecoder` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
