alamb commented on code in PR #6194:
URL: https://github.com/apache/arrow-rs/pull/6194#discussion_r1705504556


##########
object_store/src/client/retry.rs:
##########
@@ -86,6 +86,12 @@ impl Error {
                 path,
                 source: Box::new(self),
             },
+            Some(StatusCode::UNAUTHORIZED | StatusCode::FORBIDDEN) => {

Review Comment:
   I agree it it would be better to add two separate variants as the error 
cases are distinguished at the HTTP client level I think it would be the msot 
flexible if they were also distinguished at the error level
   
   We could also make this change (add a new error variant) as part of a follow 
on PR too before we made the next release



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to