crepererum commented on code in PR #6194:
URL: https://github.com/apache/arrow-rs/pull/6194#discussion_r1706686678
##########
object_store/src/client/retry.rs:
##########
@@ -86,6 +86,12 @@ impl Error {
path,
source: Box::new(self),
},
+ Some(StatusCode::UNAUTHORIZED | StatusCode::FORBIDDEN) => {
Review Comment:
Why not use the same naming as the `StatusCode`, i.e. `Unauthorized` and
`Forbidden`? I always find it useful when different layers align their naming
and you don't have to yeet through docs to find mapping from/to slightly
different wordings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
