kyle-mccarthy commented on code in PR #6194:
URL: https://github.com/apache/arrow-rs/pull/6194#discussion_r1706255605
##########
object_store/src/client/retry.rs:
##########
@@ -86,6 +86,12 @@ impl Error {
path,
source: Box::new(self),
},
+ Some(StatusCode::UNAUTHORIZED | StatusCode::FORBIDDEN) => {
Review Comment:
This sounds reasonable to me. I was originally trying to decouple it from
the protocol and keep it closer to `std::io::ErrorKind`, but am happy to change
it.
Is there a naming preference, and do we want to also rename
`PermissionDenied`? Perhaps something along the lines of `NotAuthenticated` and
`AuthorizationDenied` to distinguish between authn and authz errors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
