mapleFU commented on code in PR #43595:
URL: https://github.com/apache/arrow/pull/43595#discussion_r1706467430
##########
cpp/src/arrow/array/statistics.h:
##########
@@ -47,14 +47,14 @@ struct ARROW_EXPORT ArrayStatistics {
/// \brief The minimum value, may not be set
std::optional<ValueType> min = std::nullopt;
- /// \brief Whether the minimum value is exact or not, may not be set
- std::optional<bool> is_min_exact = std::nullopt;
+ /// \brief Whether the minimum value is exact or not
Review Comment:
This looks good to me, but IMO `is_min_exact = false` might still has exact
statistics but the reader cannot gurantee that, since
https://github.com/apache/parquet-format/pull/216 is new in 2.10 :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
