kou commented on code in PR #43595:
URL: https://github.com/apache/arrow/pull/43595#discussion_r1712561622
##########
cpp/src/arrow/array/statistics.h:
##########
@@ -47,14 +47,14 @@ struct ARROW_EXPORT ArrayStatistics {
/// \brief The minimum value, may not be set
std::optional<ValueType> min = std::nullopt;
- /// \brief Whether the minimum value is exact or not, may not be set
- std::optional<bool> is_min_exact = std::nullopt;
+ /// \brief Whether the minimum value is exact or not
Review Comment:
Are the followings correct?
1. Parquet 2.9 or earlier data don't have
`is_min_value_exact`/`is_max_value_exact`
2. Parquet 2.9 or earlier data use only exact min/max
3. Parquet 2.10 or later data use exact min/max or non-exact min/max
4. Parquet 2.10 or later data may use exact min/max without
`is_min_value_exact`/`is_max_value_exact`
You're focusing the 2. case, right? Can our Parquet reader detect Parquet
version? If so, can we always set `true` to `is_min_exact`/`is_max_exact` for
Parquet 2.9 or earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
