mapleFU commented on code in PR #43595:
URL: https://github.com/apache/arrow/pull/43595#discussion_r1719243469


##########
cpp/src/arrow/array/statistics.h:
##########
@@ -47,14 +47,14 @@ struct ARROW_EXPORT ArrayStatistics {
   /// \brief The minimum value, may not be set
   std::optional<ValueType> min = std::nullopt;
 
-  /// \brief Whether the minimum value is exact or not, may not be set
-  std::optional<bool> is_min_exact = std::nullopt;
+  /// \brief Whether the minimum value is exact or not

Review Comment:
   Sorry for late replying
   
   > Parquet 2.9 or earlier data don't have 
is_min_value_exact/is_max_value_exact
   
   Yes
   
   > Parquet 2.9 or earlier data use only exact min/max
   
   I guess no, I'll send a mail to maillist to make it sure
   
   > Parquet 2.10 or later data use exact min/max or non-exact min/max
   
   Yes
   
   > Parquet 2.10 or later data may use exact min/max without 
is_min_value_exact/is_max_value_exact
   
   right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to