felipecrv commented on code in PR #41700:
URL: https://github.com/apache/arrow/pull/41700#discussion_r1723501931
##########
cpp/src/arrow/compute/kernels/vector_selection_take_internal.cc:
##########
@@ -736,22 +1109,40 @@ void
PopulateTakeKernels(std::vector<SelectionKernelData>* out) {
auto take_indices = match::Integer();
*out = {
- {InputType(match::Primitive()), take_indices, FixedWidthTakeExec},
- {InputType(match::BinaryLike()), take_indices, VarBinaryTakeExec},
- {InputType(match::LargeBinaryLike()), take_indices,
LargeVarBinaryTakeExec},
- {InputType(match::FixedSizeBinaryLike()), take_indices,
FixedWidthTakeExec},
- {InputType(null()), take_indices, NullTakeExec},
- {InputType(Type::DICTIONARY), take_indices, DictionaryTake},
- {InputType(Type::EXTENSION), take_indices, ExtensionTake},
- {InputType(Type::LIST), take_indices, ListTakeExec},
- {InputType(Type::LARGE_LIST), take_indices, LargeListTakeExec},
- {InputType(Type::LIST_VIEW), take_indices, ListViewTakeExec},
- {InputType(Type::LARGE_LIST_VIEW), take_indices, LargeListViewTakeExec},
- {InputType(Type::FIXED_SIZE_LIST), take_indices, FSLTakeExec},
- {InputType(Type::DENSE_UNION), take_indices, DenseUnionTakeExec},
- {InputType(Type::SPARSE_UNION), take_indices, SparseUnionTakeExec},
- {InputType(Type::STRUCT), take_indices, StructTakeExec},
- {InputType(Type::MAP), take_indices, MapTakeExec},
+ {InputType(match::Primitive()), take_indices, FixedWidthTakeExec,
+ SpecialTakeChunkedExecFunctor<FixedWidthTakeExec,
+ FixedWidthTakeChunkedExec>::Exec},
+ {InputType(match::BinaryLike()), take_indices, VarBinaryTakeExec,
+ GenericTakeChunkedExecFunctor<VarBinaryTakeExec>::Exec},
+ {InputType(match::LargeBinaryLike()), take_indices,
LargeVarBinaryTakeExec,
+ GenericTakeChunkedExecFunctor<LargeVarBinaryTakeExec>::Exec},
+ {InputType(match::FixedSizeBinaryLike()), take_indices,
FixedWidthTakeExec,
+ SpecialTakeChunkedExecFunctor<FixedWidthTakeExec,
+ FixedWidthTakeChunkedExec>::Exec},
+ {InputType(null()), take_indices, NullTakeExec,
+ GenericTakeChunkedExecFunctor<NullTakeExec>::Exec},
+ {InputType(Type::DICTIONARY), take_indices, DictionaryTake,
+ GenericTakeChunkedExecFunctor<DictionaryTake>::Exec},
+ {InputType(Type::EXTENSION), take_indices, ExtensionTake,
+ GenericTakeChunkedExecFunctor<ExtensionTake>::Exec},
+ {InputType(Type::LIST), take_indices, ListTakeExec,
+ GenericTakeChunkedExecFunctor<ListTakeExec>::Exec},
+ {InputType(Type::LARGE_LIST), take_indices, LargeListTakeExec,
+ GenericTakeChunkedExecFunctor<LargeListTakeExec>::Exec},
+ {InputType(Type::LIST_VIEW), take_indices, ListViewTakeExec,
+ GenericTakeChunkedExecFunctor<ListViewTakeExec>::Exec},
+ {InputType(Type::LARGE_LIST_VIEW), take_indices, LargeListViewTakeExec,
+ GenericTakeChunkedExecFunctor<LargeListViewTakeExec>::Exec},
+ {InputType(Type::FIXED_SIZE_LIST), take_indices, FSLTakeExec,
+ GenericTakeChunkedExecFunctor<FSLTakeExec>::Exec},
Review Comment:
Yes. All the types using the generic functor will have a separate issue so I
can make struct and table filtering avoid concatenation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
