felipecrv commented on code in PR #41700:
URL: https://github.com/apache/arrow/pull/41700#discussion_r1723520874
##########
cpp/src/arrow/compute/kernels/vector_selection_take_internal.cc:
##########
@@ -395,10 +526,45 @@ struct FixedWidthTakeImpl {
out_arr->null_count = out_arr->length - valid_count;
return Status::OK();
}
+
+ static Status ChunkedExec(KernelContext* ctx, const ChunkedArray& values,
+ const ArraySpan& indices, ArrayData* out_arr,
+ int64_t factor) {
+ const bool out_has_validity = values.null_count() > 0 ||
indices.MayHaveNulls();
Review Comment:
`SpecialTakeChunkedExec` takes care of this. Look for the `single_chunk`
variable. It will call `take_aaa_exec` instead of `take_caa_exec` and then
produce a chunked array output with a single chunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
