felipecrv commented on code in PR #41700:
URL: https://github.com/apache/arrow/pull/41700#discussion_r1723514025
##########
cpp/src/arrow/compute/kernels/vector_selection_take_internal.cc:
##########
@@ -357,15 +481,22 @@ template <typename IndexCType, typename
ValueBitWidthConstant,
struct FixedWidthTakeImpl {
static constexpr int kValueWidthInBits = ValueBitWidthConstant::value;
- static Status Exec(KernelContext* ctx, const ArraySpan& values,
+ static Status Exec(KernelContext* ctx, const ValuesSpan& values,
const ArraySpan& indices, ArrayData* out_arr, int64_t
factor) {
#ifndef NDEBUG
- int64_t bit_width = util::FixedWidthInBits(*values.type);
+ int64_t bit_width = util::FixedWidthInBits(*values.type());
DCHECK(WithFactor::value || (kValueWidthInBits == bit_width && factor ==
1));
DCHECK(!WithFactor::value ||
(factor > 0 && kValueWidthInBits == 8 && // factors are used with
bytes
static_cast<int64_t>(factor * kValueWidthInBits) == bit_width));
#endif
+ return values.is_chunked()
+ ? ChunkedExec(ctx, values.chunked_array(), indices, out_arr,
factor)
+ : Exec(ctx, values.array(), indices, out_arr, factor);
+ }
+
+ static Status Exec(KernelContext* ctx, const ArraySpan& values,
Review Comment:
Related: https://github.com/apache/arrow/pull/41700#discussion_r1641239721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
