danepitkin commented on code in PR #43729:
URL: https://github.com/apache/arrow/pull/43729#discussion_r1725571016
##########
python/pyarrow/table.pxi:
##########
@@ -3436,8 +3449,18 @@ cdef class RecordBatch(_Tabular):
'{0} vs {1}'.format(len(arr), num_rows))
c_arrays.push_back(arr.sp_array)
- result = pyarrow_wrap_batch(CRecordBatch.Make(c_schema, num_rows,
- c_arrays))
+ if c_arrays.size() > 0:
+ c_device_type = deref(c_arrays[0]).device_type()
+ result = pyarrow_wrap_batch(CRecordBatch.MakeWithDevice(c_schema,
+ num_rows,
+ c_arrays,
+
c_device_type,
Review Comment:
Correct, I was following C++'s design choice. However, this can now be
removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
