jorisvandenbossche commented on code in PR #43729:
URL: https://github.com/apache/arrow/pull/43729#discussion_r1732622688
##########
python/pyarrow/lib.pxd:
##########
@@ -531,6 +531,7 @@ cdef class RecordBatch(_Tabular):
Schema _schema
cdef void init(self, const shared_ptr[CRecordBatch]& table)
+ cdef void _assert_cpu(self) except *
Review Comment:
So the conclusion is that cython still needs this one, even though it is
declared on the base class as well?
##########
python/pyarrow/lib.pxd:
##########
@@ -519,6 +519,7 @@ cdef class Table(_Tabular):
CTable* table
cdef void init(self, const shared_ptr[CTable]& table)
+ cdef void _assert_cpu(self) except *
Review Comment:
And can remove it from `RecordBatch` as well?
##########
python/pyarrow/lib.pxd:
##########
@@ -531,6 +531,7 @@ cdef class RecordBatch(_Tabular):
Schema _schema
cdef void init(self, const shared_ptr[CRecordBatch]& table)
+ cdef void _assert_cpu(self) except *
Review Comment:
So the conclusion is that cython still needs this one, even though it is
declared on the base class as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
