danepitkin commented on code in PR #43729:
URL: https://github.com/apache/arrow/pull/43729#discussion_r1725569266
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -59,10 +59,11 @@ class SimpleRecordBatch : public RecordBatch {
public:
SimpleRecordBatch(std::shared_ptr<Schema> schema, int64_t num_rows,
std::vector<std::shared_ptr<Array>> columns,
+ DeviceAllocationType device_type =
DeviceAllocationType::kCPU,
std::shared_ptr<Device::SyncEvent> sync_event = nullptr)
: RecordBatch(std::move(schema), num_rows),
boxed_columns_(std::move(columns)),
- device_type_(DeviceAllocationType::kCPU),
+ device_type_(device_type),
sync_event_(std::move(sync_event)) {
if (boxed_columns_.size() > 0) {
device_type_ = boxed_columns_[0]->device_type();
Review Comment:
Yep, you're right. I'm going to remove it because it is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
