rok commented on a change in pull request #9606:
URL: https://github.com/apache/arrow/pull/9606#discussion_r590453356
##########
File path: r/tests/testthat/test-Array.R
##########
@@ -723,6 +723,17 @@ test_that("[ accepts Arrays and otherwise handles bad
input", {
)
})
+test_that("[ %in% looks up string key in dictionary", {
+ a1 <- Array$create(as.factor(c("A", "B", "C")))
+ a2 <- DictionaryArray$create(c(0L, 1L, 2L), c(4.5, 3.2, 1.1))
+ b1 <- Array$create(c(FALSE, TRUE, FALSE))
+ b2 <- Array$create(c(FALSE, FALSE, FALSE))
+ expect_equal(b1, arrow:::call_function("is_in_meta_binary", a1,
Array$create("B")))
+ expect_equal(b2, arrow:::call_function("is_in_meta_binary", a1,
Array$create("D")))
+ expect_equal(b1, arrow:::call_function("is_in_meta_binary", a2,
Array$create(3.2)))
+ expect_error(arrow:::call_function("is_in_meta_binary", a2,
Array$create("B")))
Review comment:
I added [some doc
text](https://github.com/apache/arrow/pull/9606/files#diff-9d33f036186210a1076f3adc590e0cc60a0b65556cefdbd15e6d26aa105f7d76R112)
to `is_in`. It's a bit of copy-pasta, please review.
Shall we also add something to the
[r/NEWS.md](https://github.com/apache/arrow/blob/master/r/NEWS.md)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
