mapleFU commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1753322432
##########
cpp/src/parquet/arrow/test_util.h:
##########
@@ -142,7 +142,11 @@ template <int32_t byte_width>
static void random_decimals(int64_t n, uint32_t seed, int32_t precision,
uint8_t* out) {
auto gen = ::arrow::random::RandomArrayGenerator(seed);
std::shared_ptr<Array> decimals;
- if constexpr (byte_width == 16) {
+ if constexpr (byte_width == 4) {
+ decimals = gen.Decimal32(::arrow::decimal32(precision, 0), n);
+ } else if constexpr (byte_width == 8) {
+ decimals = gen.Decimal64(::arrow::decimal32(precision, 0), n);
Review Comment:
why ::arrow::decimal32?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
