vibhatha commented on code in PR #44078:
URL: https://github.com/apache/arrow/pull/44078#discussion_r1764396673
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java:
##########
@@ -1478,7 +1479,7 @@ protected final void handleSafe(int index, int
dataLength) {
reallocViewBuffer(Math.max(writePosition, targetCapacity));
}
- while (index >= getValueCapacity()) {
+ while (index >= getValidityBufferValueCapacity()) {
Review Comment:
I think changing to this won't hurt much. But the actual issue is just
changing the validity buffer capacity, it must be changed along with the
viewBuffer capacity as the getCapacity is a function of both changes. So just
changing one is the issue in the original code. What do you think? Am I missing
your point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
