ViggoC commented on code in PR #44078:
URL: https://github.com/apache/arrow/pull/44078#discussion_r1770748789
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java:
##########
@@ -1251,6 +1252,7 @@ public void setNull(int index) {
// We need to check and reallocate the validity buffer
while (index >= getValueCapacity()) {
reallocValidityBuffer();
+ reallocViewBuffer();
Review Comment:
I think it's a common problem. For example, BaseFixedWidthVector#setNull
also reallocate validity buffer and data buffer at same time. By the way, I
think we can simplify this while block to `handleSafe(index, 0)` if we do need
to realloc view buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
