vibhatha commented on code in PR #44078:
URL: https://github.com/apache/arrow/pull/44078#discussion_r1764395277
##########
java/vector/src/test/java/org/apache/arrow/vector/TestVarCharViewVector.java:
##########
@@ -261,6 +261,15 @@ public void testDataBufferBasedAllocationInOtherBuffer() {
}
}
+ @Test
+ public void testSetSafe() {
Review Comment:
I think the issue here is that the `getValueCapacity` depends on the
capacity of the `viewBuffer` and `validityBuffer`, so in the while loop, when
just one is changed, and the other value is kept the same, the minimum will
always be the unchanged value. So I think the main issue is the error in that
function. Thank you for this test case, I don't think the existing test cases
covered this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
