ShiKaiWi opened a new pull request, #6427:
URL: https://github.com/apache/arrow-rs/pull/6427
…rray` for faster `slice`
# Which issue does this PR close?
Close #6408
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
In the `GenericByteViewArray`, the `buffers` field is a raw vector, leading
to heap allocation when some methods, e.g. `clone`, `slice`. Using
`Arc<[Buffer]>` instead of the raw `Vec<Buffer>` can avoid such heap allocation.
(TODO: add the benchmark results when the benchmark case is added)
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Use `Arc<[Buffer]>` instead of the raw `Vec<Buffer>` as the type of
`buffers` field of `GenericByteViewArray`.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
The signature of the method `GenericByteViewArray::new_unchecked` is changed
from:
```
pub unsafe fn new_unchecked(
views: ScalarBuffer<u128>,
buffers: Vec<[Buffer]>,
nulls: Option<NullBuffer>,
) -> Self;
```
to
```
pub unsafe fn new_unchecked(
views: ScalarBuffer<u128>,
buffers: impl Into<Arc<[Buffer]>>,
nulls: Option<NullBuffer>,
) -> Self;
```
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
