ByteBaker commented on code in PR #6424:
URL: https://github.com/apache/arrow-rs/pull/6424#discussion_r1768927128
##########
arrow/src/pyarrow.rs:
##########
@@ -77,23 +77,32 @@ use crate::ffi_stream::{ArrowArrayStreamReader,
FFI_ArrowArrayStream};
use crate::record_batch::RecordBatch;
import_exception!(pyarrow, ArrowException);
+/// Represents an exception raised by PyArrow.
pub type PyArrowException = ArrowException;
fn to_py_err(err: ArrowError) -> PyErr {
PyArrowException::new_err(err.to_string())
}
+/// Trait for converting PyArrow objects to arrow-rs types, opposite of
[ToPyArrow] or [IntoPyArrow].
+///
+/// This is an easy way to keep track of the types that have been implemented.
Review Comment:
Since this module is for Python bindings through PyO3, there are
intermediate types. For communicating with Python/PyO3 subroutines, we have
PyArrow objects.
But I supposed you're referring more to the 2nd line. I only meant that
having a trait implemented would allow us to keep track of all the types that
support the given operation.
Do you have a suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
