ByteBaker commented on code in PR #6433:
URL: https://github.com/apache/arrow-rs/pull/6433#discussion_r1769530220
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -537,7 +537,7 @@ mod tests {
write!(builder, "buz").unwrap();
builder.append_value("");
let a = builder.finish();
- let r: Vec<_> = a.iter().map(|x| x.unwrap()).collect();
+ let r: Vec<_> = a.iter().flatten().collect();
Review Comment:
Right. I realized when I made the change, but as you said, the test works
while avoiding any potential panic (at least semantically), so I went ahead
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
