ByteBaker commented on code in PR #6433:
URL: https://github.com/apache/arrow-rs/pull/6433#discussion_r1769530287
##########
arrow-schema/src/ffi.rs:
##########
@@ -274,35 +282,59 @@ impl FFI_ArrowSchema {
}
}
+ /// Returns the flags of this schema.
pub fn flags(&self) -> Option<Flags> {
Flags::from_bits(self.flags)
}
+ /// Returns the child of this schema at `index`.
+ ///
+ /// # Panics
+ ///
+ /// Panics if `index` is greater than or equal to the number of children.
+ ///
+ /// This is to make sure that the unsafe acces to raw pointer is sound.
+ ///
+ /// # Safety
Review Comment:
Understood. I'll make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
