lidavidm commented on code in PR #44078:
URL: https://github.com/apache/arrow/pull/44078#discussion_r1770757507
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java:
##########
@@ -1251,6 +1252,7 @@ public void setNull(int index) {
// We need to check and reallocate the validity buffer
while (index >= getValueCapacity()) {
reallocValidityBuffer();
+ reallocViewBuffer();
Review Comment:
I think it would be bad here to only reallocate the validity buffer without
also expanding the view buffer, since you could reasonably conclude after
setNull that there should at least be storage for the slot even if it's null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
