vibhatha commented on code in PR #44187:
URL: https://github.com/apache/arrow/pull/44187#discussion_r1771181233
##########
java/vector/src/main/java/org/apache/arrow/vector/ViewVarCharVector.java:
##########
@@ -279,6 +313,7 @@ public TransferPair makeTransferPair(ValueVector to) {
}
private class TransferImpl implements TransferPair {
+
Review Comment:
Needed?
##########
java/vector/src/test/java/org/apache/arrow/vector/TestVarCharViewVector.java:
##########
@@ -371,6 +373,67 @@ public void testMixedAllocation() {
}
}
+ @Test
+ public void testSetNullableViewVarCharHolder() {
+ try (final ViewVarCharVector viewVarCharVector = new
ViewVarCharVector("myvector", allocator)) {
+ viewVarCharVector.allocateNew(0, 0);
+ final List<byte[]> strings = List.of(STR0, STR1, STR2, STR3, STR4, STR5);
+
+ NullableViewVarCharHolder stringHolder = new NullableViewVarCharHolder();
+
+ setAndCheck(viewVarCharVector, 1, strings.get(0), stringHolder);
Review Comment:
To check overwrite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
