vibhatha commented on code in PR #44187:
URL: https://github.com/apache/arrow/pull/44187#discussion_r1774364597
##########
java/vector/src/main/java/org/apache/arrow/vector/ViewVarCharVector.java:
##########
@@ -186,9 +213,16 @@ public void setSafe(int index, ViewVarCharHolder holder) {
* @param holder holder that carries data buffer.
*/
public void set(int index, NullableViewVarCharHolder holder) {
- // TODO: https://github.com/apache/arrow/issues/40937
- throw new UnsupportedOperationException(
- "NullableViewVarCharHolder set operation not supported");
+ if (holder.isSet == 0) {
+ setNull(index);
+ } else {
+ BitVectorHelper.setBit(validityBuffer, index);
+ int start = holder.start;
+ int length = holder.end - start;
+ ArrowBuf dataBuf = holder.buffer;
Review Comment:
inline this?
##########
java/vector/src/main/java/org/apache/arrow/vector/ViewVarCharVector.java:
##########
@@ -162,8 +185,11 @@ public void get(int index, NullableViewVarCharHolder
holder) {
* @param holder holder that carries data buffer.
*/
public void set(int index, ViewVarCharHolder holder) {
- // TODO: https://github.com/apache/arrow/issues/40937
- throw new UnsupportedOperationException("ViewVarCharHolder set operation
not supported");
+ int start = holder.start;
+ int length = holder.end - start;
+ ArrowBuf dataBuf = holder.buffer;
Review Comment:
inline this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
