ViggoC commented on code in PR #44187:
URL: https://github.com/apache/arrow/pull/44187#discussion_r1771699281
##########
java/vector/src/test/java/org/apache/arrow/vector/TestVarCharViewVector.java:
##########
@@ -371,6 +373,67 @@ public void testMixedAllocation() {
}
}
+ @Test
+ public void testSetNullableViewVarCharHolder() {
+ try (final ViewVarCharVector viewVarCharVector = new
ViewVarCharVector("myvector", allocator)) {
+ viewVarCharVector.allocateNew(0, 0);
+ final List<byte[]> strings = List.of(STR0, STR1, STR2, STR3, STR4, STR5);
+
+ NullableViewVarCharHolder stringHolder = new NullableViewVarCharHolder();
+
+ setAndCheck(viewVarCharVector, 1, strings.get(0), stringHolder);
Review Comment:
I think it's not needed. It's just missed it while adjusting the code. But
you reminded me that it is necessary to add some overwrite test cases.
##########
java/vector/src/test/java/org/apache/arrow/vector/TestVarCharViewVector.java:
##########
@@ -371,6 +373,67 @@ public void testMixedAllocation() {
}
}
+ @Test
+ public void testSetNullableViewVarCharHolder() {
+ try (final ViewVarCharVector viewVarCharVector = new
ViewVarCharVector("myvector", allocator)) {
+ viewVarCharVector.allocateNew(0, 0);
+ final List<byte[]> strings = List.of(STR0, STR1, STR2, STR3, STR4, STR5);
+
+ NullableViewVarCharHolder stringHolder = new NullableViewVarCharHolder();
+
+ setAndCheck(viewVarCharVector, 1, strings.get(0), stringHolder);
Review Comment:
I think it's not needed. I just missed it while adjusting the code. But you
reminded me that it is necessary to add some overwrite test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
