alamb commented on code in PR #6303:
URL: https://github.com/apache/arrow-rs/pull/6303#discussion_r1777376566
##########
arrow-array/src/array/union_array.rs:
##########
@@ -380,6 +392,254 @@ impl UnionArray {
_ => unreachable!(),
}
}
+
+ /// Computes the logical nulls for a sparse union, optimized for when
there's a lot of fields without nulls
+ fn mask_sparse_skip_without_nulls(&self, nulls: Vec<(i8, NullBuffer)>) ->
BooleanBuffer {
Review Comment:
I don't think we have any strict policy -- rather the guidelines are to
cover the code such that if someone broke it accidentally in a future
refactoring, the tests would break.
Exactly how much coverage is enough to meet that bar I think is somewhat of
a judgement call and is based on the functionality.
Perhaps you can help @gstvg figure out any missing cases they could add
based on your coverage analysis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
