wiedld commented on code in PR #6303:
URL: https://github.com/apache/arrow-rs/pull/6303#discussion_r1777486806
##########
arrow-array/src/array/union_array.rs:
##########
@@ -380,6 +392,254 @@ impl UnionArray {
_ => unreachable!(),
}
}
+
+ /// Computes the logical nulls for a sparse union, optimized for when
there's a lot of fields without nulls
+ fn mask_sparse_skip_without_nulls(&self, nulls: Vec<(i8, NullBuffer)>) ->
BooleanBuffer {
Review Comment:
Sure thing. Here is the [cov
report](https://github.com/user-attachments/files/17153113/cov_union_arrays.tar.gz).
I added in `assert!(false)` lines for verification of coverage gaps; also
makes skimming the report easier.
<details>
<p>
```
# to open
> tar -xvf cov_union_arrays.tar.gz
> open cov_union_arrays.html
# how generated
> RUSTFLAGS='-Z profile -C codegen-units=1'
CARGO_CFG_REGEX_DISABLE_AUTO_OPTIMIZATIONS=1 cargo +nightly cov test -p
arrow-array --lib
> cargo +nightly cov report --open
# save as complete webpage (give you interactive bits), and tarball
# Also confirmed the arrow-arith tests did not increase coverage.
# Only the benchmarks did -- and those don't check correctness.
```
</p>
</details>
Your call on wherever you want correctness coverage @gstvg . Hope this
helps!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
