alamb commented on code in PR #6303:
URL: https://github.com/apache/arrow-rs/pull/6303#discussion_r1777666866
##########
arrow-array/src/array/union_array.rs:
##########
@@ -380,6 +392,254 @@ impl UnionArray {
_ => unreachable!(),
}
}
+
+ /// Computes the logical nulls for a sparse union, optimized for when
there's a lot of fields without nulls
+ fn mask_sparse_skip_without_nulls(&self, nulls: Vec<(i8, NullBuffer)>) ->
BooleanBuffer {
Review Comment:
I was thinking it would help to translate the codecov report into a
description of what UnionArray should be constructed / have `logical_nulls`
called on it to improve the coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
