ianmcook commented on a change in pull request #9681:
URL: https://github.com/apache/arrow/pull/9681#discussion_r592806098
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -846,6 +846,38 @@ test_that("mutate() with NULL inputs", {
)
})
+test_that("empty mutate()", {
+ expect_equal(
+ ds %>%
+ mutate() %>%
+ collect(),
+ ds %>%
+ collect()
+ )
+})
+
+test_that("transmute() with NULL inputs", {
+ expect_equal(
+ ds %>%
+ transmute(int = NULL) %>%
+ collect(),
+ ds %>%
+ select() %>%
Review comment:
> I'm not sure that you need the tests both here and in
test-dplyr-mutate.R--they're using the same R code.
I recognized that the tests currently exercise the same code but I included
them both because it seemed safer not to assume that they always would in the
future. Do you prefer I remove the duplicate tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
