nealrichardson commented on a change in pull request #9681:
URL: https://github.com/apache/arrow/pull/9681#discussion_r592809181



##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -846,6 +846,38 @@ test_that("mutate() with NULL inputs", {
   )
 })
 
+test_that("empty mutate()", {
+  expect_equal(
+    ds %>%
+      mutate() %>%
+      collect(),
+    ds %>%
+      collect()
+  )
+})
+
+test_that("transmute() with NULL inputs", {
+  expect_equal(
+    ds %>%
+      transmute(int = NULL) %>%
+      collect(),
+    ds %>%
+      select() %>%

Review comment:
       It's a fair point. My bigger concern is that I think they're asserting 
wrong results because of ARROW-11328, so there's not much value at this time. 
But it's fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to