ianmcook commented on a change in pull request #9681:
URL: https://github.com/apache/arrow/pull/9681#discussion_r592808241
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -846,6 +846,38 @@ test_that("mutate() with NULL inputs", {
)
})
+test_that("empty mutate()", {
+ expect_equal(
+ ds %>%
+ mutate() %>%
+ collect(),
+ ds %>%
+ collect()
+ )
+})
+
+test_that("transmute() with NULL inputs", {
+ expect_equal(
+ ds %>%
+ transmute(int = NULL) %>%
+ collect(),
+ ds %>%
+ select() %>%
Review comment:
> Also see
[ARROW-11328](https://issues.apache.org/jira/browse/ARROW-11328), which
suggests `select()` doesn't do what is expected for Datasets, so this test
would mean that both are wrong here. (It's a separate problem, about the C++
library and not the R NSE code, so I wouldn't solve it here.)
That behavior seems to have been fixed since the 3.0.0 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
