mbrobbel commented on code in PR #6551:
URL: https://github.com/apache/arrow-rs/pull/6551#discussion_r1799287067
##########
arrow-buffer/src/util/bit_mask.rs:
##########
@@ -127,16 +127,16 @@ unsafe fn set_upto_64bits(
}
/// # Safety
-/// The caller must ensure all arguments are within the valid range.
+/// The caller must ensure `data` has `offset..(offset + 8)` range
#[inline]
unsafe fn read_bytes_to_u64(data: &[u8], offset: usize, count: usize) -> u64 {
debug_assert!(count <= 8);
- let mut tmp = std::mem::MaybeUninit::<u64>::new(0);
+ let mut tmp : u64 = 0;
let src = data.as_ptr().add(offset);
unsafe {
- std::ptr::copy_nonoverlapping(src, tmp.as_mut_ptr() as *mut u8, count);
- tmp.assume_init()
+ std::ptr::copy_nonoverlapping(src, &mut tmp as *mut _ as *mut u8,
count);
Review Comment:
Shouldn't we restrict the number of bytes copied to 8 here? The destination
is not valid for more writes.
```suggestion
std::ptr::copy_nonoverlapping(src, &mut tmp as *mut _ as *mut u8,
count.min(8));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
