kazuyukitanimura commented on code in PR #6551:
URL: https://github.com/apache/arrow-rs/pull/6551#discussion_r1802118010
##########
arrow-buffer/src/util/bit_mask.rs:
##########
@@ -127,16 +127,16 @@ unsafe fn set_upto_64bits(
}
/// # Safety
-/// The caller must ensure all arguments are within the valid range.
+/// The caller must ensure `data` has `offset..(offset + 8)` range, and `count
<= 8`.
#[inline]
unsafe fn read_bytes_to_u64(data: &[u8], offset: usize, count: usize) -> u64 {
debug_assert!(count <= 8);
- let mut tmp = std::mem::MaybeUninit::<u64>::new(0);
+ let mut tmp: u64 = 0;
Review Comment:
@ssbr This is a performance sensitive area.
Would you mind benchmarking the followings and compare before and after?
(maybe several times as the results may vary due to noise)
```
cd arrow-buffer
cargo bench --bench boolean_append_packed
cargo bench --bench bit_mask
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
