alamb commented on code in PR #6551:
URL: https://github.com/apache/arrow-rs/pull/6551#discussion_r1801972146


##########
arrow-buffer/src/util/bit_mask.rs:
##########
@@ -127,16 +127,16 @@ unsafe fn set_upto_64bits(
 }
 
 /// # Safety
-/// The caller must ensure all arguments are within the valid range.
+/// The caller must ensure `data` has `offset..(offset + 8)` range, and `count 
<= 8`.

Review Comment:
   @kazuyukitanimura  can you please review this change? I believe it was 
introduced as part of https://github.com/apache/arrow-rs/pull/6288
   
   
https://github.com/apache/arrow-rs/blame/b945b15de9085f5961a478d4f35b0c5c3427e248/arrow-buffer/src/util/bit_mask.rs#L132



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to