WillAyd commented on code in PR #2261:
URL: https://github.com/apache/arrow-adbc/pull/2261#discussion_r1806953699
##########
c/driver/postgresql/result_helper.h:
##########
@@ -89,7 +89,7 @@ class PqResultRow {
PqResultRow() : result_(nullptr), row_num_(-1) {}
PqResultRow(PGresult* result, int row_num) : result_(result),
row_num_(row_num) {}
- PqRecord operator[](const int& col_num) const {
+ PqRecord operator[](int col_num) const noexcept {
Review Comment:
Note the change in the paramater declaration from `const int&` to `int`
It may not matter, but I believe the reference type just adds an unnecessary
layer of indirection
##########
c/driver/postgresql/result_helper.h:
##########
@@ -89,7 +89,7 @@ class PqResultRow {
PqResultRow() : result_(nullptr), row_num_(-1) {}
PqResultRow(PGresult* result, int row_num) : result_(result),
row_num_(row_num) {}
- PqRecord operator[](const int& col_num) const {
+ PqRecord operator[](int col_num) const noexcept {
Review Comment:
Note the change in the paramater declaration from `const int&` to `int`
It may not matter, but I believe the const reference type just adds an
unnecessary layer of indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
