WillAyd commented on PR #2261: URL: https://github.com/apache/arrow-adbc/pull/2261#issuecomment-2425189188
> I don't see any problems with this if it works, but we don't aggresively define `noexcept` in other places and I'm wondering why that is? Researching this some more I think there may be too much usage of noexcept in the current PR implementation. Here are guidelines I found from the stdlib: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3279.pdf My take on it is that many of these methods are "narrow" (i.e. they have some precondition / state) so probably not worth marking this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
