WillAyd commented on PR #2261: URL: https://github.com/apache/arrow-adbc/pull/2261#issuecomment-2426671415
OK cool - I'll scale the noexcept back a lot here. > Any memory allocation may throw FWIW the cpp core guidelines suggest that you may still want to mark functions that can throw because of OOM issues as noexcept: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f6-if-your-function-must-not-throw-declare-it-noexcept -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
