findepi commented on PR #6608: URL: https://github.com/apache/arrow-rs/pull/6608#issuecomment-2426474043
@tustvold thank you for taking time to review this PR! > I'm not sure about this, in all cases where there can be logical nulls, apart from NullArray, this will involve computing the full logical null mask only to throw it away. Good point. this is what callers that need to find out number of logical nulls have to do today. Examples: https://github.com/apache/datafusion/blob/e9584bc46ffc574cd65044d4199966402def1d15/datafusion/functions-aggregate/src/count.rs#L605-L607, https://github.com/apache/datafusion/pull/13029 Having this function on the Array itself allows us to provide better implementation. This PR does this for all primitive types, boolean array and null array -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
