tustvold commented on code in PR #6608:
URL: https://github.com/apache/arrow-rs/pull/6608#discussion_r1809462908
##########
arrow-array/src/array/null_array.rs:
##########
@@ -116,8 +117,8 @@ impl Array for NullArray {
(self.len != 0).then(|| NullBuffer::new_null(self.len))
}
- fn is_nullable(&self) -> bool {
- !self.is_empty()
+ fn logical_null_count(&self) -> usize {
+ self.len
Review Comment:
> Nevermind, I see that the default impl of is_nullable now uses
logical_null_count :)
Yeah, which is the wrong way round... is_nullable should be the cheaper
call...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
